Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @GET | ||
| @Produces(MediaType.TEXT_PLAIN) | ||
| public String hello() { | ||
| var test = doSpotBugsDemo(); |
There was a problem hiding this comment.
The local variable test is assigned but never used. Remove this variable or utilize its value in the method logic.
Suggested change
| var test = doSpotBugsDemo(); |
|
|
||
| private String doSpotBugsDemo(){ | ||
| private String doSpotBugsDemo() { | ||
| var test2 = "Esta es una pesima forma de programar"; |
There was a problem hiding this comment.
The local variable test2 is assigned but never used. Remove this variable or utilize its value in the method logic.
Suggested change
| var test2 = "Esta es una pesima forma de programar"; |
|
|
||
| private String doSpotBugsDemo(){ | ||
| private String doSpotBugsDemo() { | ||
| var test2 = "Esta es una pesima forma de programar"; |
There was a problem hiding this comment.
Corrected spelling of 'pesima' to 'pésima' (missing accent mark in Spanish).
Suggested change
| var test2 = "Esta es una pesima forma de programar"; | |
| var test2 = "Esta es una pésima forma de programar"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two minor changes to the
GreetingResourceclass, primarily adding unused local variables to demonstrate poor programming practices for a SpotBugs demo.testandtest2in thehelloanddoSpotBugsDemomethods to illustrate code quality issues for SpotBugs demonstration purposes.